Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds renovate config #19

Merged
merged 2 commits into from
Dec 22, 2024
+15 −0
Merged

chore: adds renovate config #19

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
249eb8b
chore: adds renovate config
Gowiem Dec 22, 2024
8ef447c
chore: move renovate config to .github not workflows/
Gowiem Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"extends": [
"config:recommended",
"github>aquaproj/aqua-renovate-config#2.6.0"
],
"schedule": ["before 5am on Monday"],
"baseBranches": ["main", "master"],
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Remove 'master' from baseBranches as 'main' is the default branch

The repository is using main as the default branch, so including master in baseBranches is unnecessary and may cause confusion. Consider updating the configuration to only target the active default branch.

🔗 Analysis chain

Verify primary branch naming convention

The configuration targets both main and master branches. This might indicate inconsistent branch naming across repositories.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check which default branch is actually in use
git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@'

Length of output: 82

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have repositories that are still on master. This is intended to be a shared config for all repositories. I'm just trying it out here. You can safely ignore this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gowiem, understood! We’ll ignore this suggestion for now. Thanks for clarifying that some of your repositories still use the master branch.

✏️ Learnings added 
Learnt from: Gowiem
PR: masterpointio/terraform-spacelift-automation#19
File: .github/workflows/renovate.json5:7-7
Timestamp: 2024-12-22T19:36:59.395Z
Learning: Some of Gowiem's repositories still use 'master' as the primary branch, so they intentionally keep "master" in Renovate's baseBranches for a shared configuration.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

"labels": ["auto-upgrade"],
"dependencyDashboardAutoclose": true,
"terraform": {
"ignorePaths": [
"**/context.tf",
]
},
}
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Move Renovate configuration file to the standard location

The Renovate configuration file is currently located at .github/workflows/renovate.json5, but this is not a standard location. For better compatibility and to ensure Renovate detects it properly, please move the configuration file to one of these standard locations:

  • .github/renovate.json
  • .github/renovate.json5
  • renovate.json
  • renovate.json5
🔗 Analysis chain

Verify Renovate configuration file location

The configuration looks good overall, but let's verify if it's in the standard location that Renovate expects.

The previous command had an error, so let's try a different approach to verify the location. The standard locations for Renovate configuration are:

  1. renovate.json
  2. .renovaterc
  3. .github/renovate.json
  4. .gitlab/renovate.json
  5. package.json (with "renovate" key)

Let's check these locations with a different command.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if renovate config exists in standard locations
fd -g 'renovate.json*' -g '.renovaterc*' .

Length of output: 103

Script:

#!/bin/bash
# Let's try a different approach to find the renovate configuration file
find . -type f -name 'renovate.json*' -o -name '.renovaterc*'

# Also check the content of .github directory specifically
ls -la .github/

Length of output: 471

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout. I will move it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gowiem, thanks for the prompt response! Looking forward to the updated config file. Let me know if there’s anything else you’d like me to review or assist with.

Loading