From 9c749ffa1f2a515e27d3340463c6aeaf68f1fc21 Mon Sep 17 00:00:00 2001 From: Veronika Gnilitska Date: Mon, 18 Nov 2024 07:39:07 -0500 Subject: [PATCH] chore: CRabbit suggestions --- README.md | 6 +++++- examples/complete/versions.tf | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 395eb73..95f08bd 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,8 @@ It allows to define and manage multiple AWS integrations within Spacelift, facil This module replaces the deprecated `spacelift_aws_role` resource and [is recommended](https://registry.terraform.io/providers/spacelift-io/spacelift/latest/docs/resources/aws_role) for use instead. +Before creating the Spacelift AWS integration, _you need to have an AWS IAM Role_ within your AWS account that the cloud integration will use. + ## Usage Here’s an example of how to use this module in your Terraform configuration: @@ -21,14 +23,16 @@ module "spacelift_aws_integrations" { aws_integrations = { "prod" = { aws_account_id = "123456789012" + role_arn = "arn:aws:iam::123456789012:role/spacelift" duration_seconds = 1200 generate_credentials_in_worker = true labels = ["prod", "team:sre"] }, "dev" = { aws_account_id = "210987654321" + role_arn = "arn:aws:iam::210987654321:role/spacelift" external_id = "dev-external-id" - space_id = "custom_space" + space_id = "custom-space" } } } diff --git a/examples/complete/versions.tf b/examples/complete/versions.tf index a7d1d5d..9904eab 100644 --- a/examples/complete/versions.tf +++ b/examples/complete/versions.tf @@ -1,10 +1,10 @@ terraform { - required_version = "~> 1.0" + required_version = ">= 1.0" required_providers { spacelift = { source = "spacelift-io/spacelift" - version = "~> 1.0" + version = ">= 1.0" } } }