Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vcr cache for hosts with explicit port #104

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

pietdevries94
Copy link
Contributor

@pietdevries94 pietdevries94 commented Oct 9, 2024

The following test creates a vcr file that with a filename that is not viable on all platforms
// xing.com:443 - https with port

The golang sum db now returns the following.
https://sum.golang.org/lookup/github.com/mat/besticon/v3@v3.20.0

not found: create zip: besticon/testdata/xing.com:443.vcr: malformed file path "besticon/testdata/xing.com:443.vcr": invalid char ':'

This small fix replaces : with _, making sure it's still a valid file name.

My editor also complained about an unused err check, which I also cleaned up in a separate commit.

@mat mat merged commit d514ea5 into mat:master Oct 9, 2024
3 checks passed
@mat
Copy link
Owner

mat commented Oct 9, 2024

Thanks @pietdevries94 for this fix!

@pietdevries94 pietdevries94 deleted the patch-1 branch October 10, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants