solution #542
Open
solution #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Oct 23, 2023
|
It`s work with 'a' ,'d', 'w', 's'. please try |
denys-danyliuk
suggested changes
Oct 23, 2023
denys-danyliuk
suggested changes
Oct 24, 2023
sTorba24
suggested changes
Oct 25, 2023
src/scripts/main.js
Outdated
Comment on lines
233
to
256
| document.addEventListener('keydown', e => { | ||
| switch (e.key) { | ||
| case 'a': { | ||
| moveHorizontally(left); | ||
| break; | ||
| } | ||
|
|
||
| case 'd': { | ||
| moveHorizontally(right); | ||
| break; | ||
| } | ||
|
|
||
| case 'w': { | ||
| moveVertically(up); | ||
| break; | ||
| } | ||
|
|
||
| case 's': { | ||
| moveVertically(down); | ||
| break; | ||
| } | ||
| } | ||
| loseCheck(); | ||
| }); |
There was a problem hiding this comment.
add also ability to use arrows, will be really good improvement
src/scripts/main.js
Outdated
Comment on lines
266
to
327
| // const gameTable = document.querySelector('.game-field'); | ||
|
|
||
| // let touchStartX = 0; | ||
| // let touchStartY = 0; | ||
|
|
||
| // document.addEventListener('touchmove', (e) => { | ||
| // e.preventDefault(); | ||
| // }); | ||
|
|
||
| // gameTable.addEventListener('touchmove', (e) => { | ||
| // e.preventDefault(); | ||
| // }); | ||
|
|
||
| // gameTable.addEventListener('touchstart', (e) => { | ||
| // touchStartX = e.touches[0].clientX; | ||
| // touchStartY = e.touches[0].clientY; | ||
| // }); | ||
|
|
||
| // gameTable.addEventListener('touchend', (e) => { | ||
| // const touchEndX = e.changedTouches[0].clientX; | ||
| // const touchEndY = e.changedTouches[0].clientY; | ||
| // const touchDiffX = touchEndX - touchStartX; | ||
| // const touchDiffY = touchEndY - touchStartY; | ||
| // const breakPoint = 50; | ||
|
|
||
| // if (Math.abs(touchDiffX) > Math.abs(touchDiffY)) { | ||
| // if (touchDiffX > breakPoint) { | ||
| // moveHorizontally(right); | ||
| // loseCheck(); | ||
| // } else if (touchDiffX < -1 * breakPoint) { | ||
| // moveHorizontally(left); | ||
| // loseCheck(); | ||
| // } else if (touchDiffY > breakPoint) { | ||
| // moveVertically(down); | ||
| // loseCheck(); | ||
| // } else if (touchDiffY < -1 * breakPoint) { | ||
| // moveVertically(up); | ||
| // loseCheck(); | ||
| // } | ||
|
|
||
| // switch (true) { | ||
| // case (touchDiffX > breakPoint): | ||
| // moveHorizontally(right); | ||
| // break; | ||
| // case (touchDiffX < -1 * breakPoint): | ||
| // moveHorizontally(left); | ||
| // break; | ||
| // case (touchDiffY > breakPoint): | ||
| // moveVertically(down); | ||
| // break; | ||
| // case (touchDiffY < -1 * breakPoint): | ||
| // moveVertically(up); | ||
| // break; | ||
| // default: return 0; | ||
| // } | ||
| // loseCheck(); | ||
| // } | ||
| // }); | ||
|
|
||
| // document.addEventListener('touchmove', (e) => { | ||
| // e.preventDefault(); | ||
| // }); |
etojeDenys
suggested changes
Oct 25, 2023
Comment on lines
+235
to
+243
| case 'a': { | ||
| moveHorizontally(left); | ||
| break; | ||
| } | ||
|
|
||
| case 'ArrowLeft': { | ||
| moveHorizontally(left); | ||
| break; | ||
| } |
There was a problem hiding this comment.
we can combine these cases
Suggested change
| case 'a': { | |
| moveHorizontally(left); | |
| break; | |
| } | |
| case 'ArrowLeft': { | |
| moveHorizontally(left); | |
| break; | |
| } | |
| case 'a': | |
| case 'ArrowLeft': { | |
| moveHorizontally(left); | |
| break; | |
| } |
There was a problem hiding this comment.
Unfortunately, the linter requires a 'break' after each 'case'. I asked this question in the chat, In this case it is impossible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.