2048 #544
Open
2048 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Oct 24, 2023
loralevitska
suggested changes
Oct 24, 2023
nazarmatsevych
suggested changes
Oct 24, 2023
src/scripts/main.js
Outdated
| } | ||
| } | ||
|
|
||
| if (number === 2048) { |
There was a problem hiding this comment.
Suggested change
| if (number === 2048) { | |
| if (number === 2048) { |
Move magic numbers like 2048 to constant
src/scripts/main.js
Outdated
Comment on lines
59
to
66
| const hasEmptyCell = () => { | ||
| for (let r = 0; r < rows; r++) { | ||
| for (let c = 0; c < columns; c++) { | ||
| if (board[r][c] === 0) { | ||
| return true; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You can use a "some" method here to reduce the amount of code a bit
src/scripts/main.js
Outdated
Comment on lines
224
to
264
| const slideLeft = () => { | ||
| for (let r = 0; r < rows; r++) { | ||
| let row = board[r]; | ||
|
|
||
| row = slide(row); | ||
| board[r] = row; | ||
|
|
||
| for (let c = 0; c < columns; c++) { | ||
| const cell = document.getElementById(`row_${r}-column_${c}`); | ||
| const number = board[r][c]; | ||
|
|
||
| updateCell(cell, number); | ||
| } | ||
| } | ||
|
|
||
| if (hasChanges(initialBoard, board)) { | ||
| setCell(); | ||
| } | ||
| }; | ||
|
|
||
| const slideRight = () => { | ||
| for (let r = 0; r < rows; r++) { | ||
| let row = board[r]; | ||
|
|
||
| row.reverse(); | ||
| row = slide(row); | ||
| row.reverse(); | ||
| board[r] = row; | ||
|
|
||
| for (let c = 0; c < columns; c++) { | ||
| const cell = document.getElementById(`row_${r}-column_${c}`); | ||
| const number = board[r][c]; | ||
|
|
||
| updateCell(cell, number); | ||
| } | ||
| } | ||
|
|
||
| if (hasChanges(initialBoard, board)) { | ||
| setCell(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This functions looks similar, i think we can try to combine them
volodymyr-soltys97
suggested changes
Oct 25, 2023
src/scripts/main.js
Outdated
| @@ -1,3 +1,345 @@ | |||
| 'use strict'; | |||
|
|
|||
| // write your code here | |||
| const MAGIC_NUMBER = 2048; | |||
There was a problem hiding this comment.
Suggested change
| const MAGIC_NUMBER = 2048; | |
| const WINNER_SCORE = 2048; |
src/scripts/main.js
Outdated
| } | ||
|
|
||
| switch (arrow.key) { | ||
| case 'ArrowLeft': |
There was a problem hiding this comment.
Move all these magic words to variables and use it everywhere
anastasiiavorobiova
suggested changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LING