Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am having issues with the num generator not always seeing that a sq… #550

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

spencerspe
Copy link

…uare is filled. The rest of the code is still being worked on
- DEMO LINK

…uare is filled. The rest of the code is still being worked on
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed the problem in chat

Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

but we have some bugs here)

  1. field shouldn't have any cells on page loading
  2. cells should appear after start button click
  3. when game is not started pressing keys should cause nothing
  4. I can press one button (for example 'down') new cells will always appear. But they should appear only if something changed on the move (cells were moved or merged)
  5. the game is over but there are still options for moves
    image

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants