Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1557

wants to merge 1 commit into from

Conversation

Sholudyvyy
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the solution! 🎉 The code effectively meets the task requirements by calculating and formatting the total and average population. Just a small note: consider adding a check to handle cases where there might be no elements with the class 'population' to avoid division by zero. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +15 to +17
document.querySelector('span.average-population').innerHTML = Intl.NumberFormat(
'en-US',
).format(total / matches.length);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential issue when calculating the average population. If there are no elements with the class 'population', matches.length will be zero, leading to a division by zero error. Consider adding a check to ensure matches.length is not zero before performing the division.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants