Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #1571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #1571

wants to merge 1 commit into from

Conversation

futdevelop
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the solution! 🎉 The code meets all the task requirements and constraints effectively. Just make sure to verify that the necessary elements exist in the DOM to prevent any potential runtime errors. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,3 +1,20 @@
'use strict';

// write your code here
const populationElements = document.querySelectorAll('span.population');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that there are elements with the class 'population' in the DOM. If there are none, this will result in an empty NodeList, and subsequent operations will not work as expected.


const averagePopulation = totalPopulation / populations.length;

const totalPopSpan = document.querySelector('span.total-population');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that there is an element with the class 'total-population' in the DOM. If this element does not exist, this line will result in a null reference error when trying to set the textContent.

const averagePopulation = totalPopulation / populations.length;

const totalPopSpan = document.querySelector('span.total-population');
const averagePopSpan = document.querySelector('span.average-population');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that there is an element with the class 'average-population' in the DOM. If this element does not exist, this line will result in a null reference error when trying to set the textContent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants