-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #1571
base: master
Are you sure you want to change the base?
add solution #1571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the solution! 🎉 The code meets all the task requirements and constraints effectively. Just make sure to verify that the necessary elements exist in the DOM to prevent any potential runtime errors. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -1,3 +1,20 @@ | |||
'use strict'; | |||
|
|||
// write your code here | |||
const populationElements = document.querySelectorAll('span.population'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that there are elements with the class 'population' in the DOM. If there are none, this will result in an empty NodeList, and subsequent operations will not work as expected.
|
||
const averagePopulation = totalPopulation / populations.length; | ||
|
||
const totalPopSpan = document.querySelector('span.total-population'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that there is an element with the class 'total-population' in the DOM. If this element does not exist, this line will result in a null reference error when trying to set the textContent.
const averagePopulation = totalPopulation / populations.length; | ||
|
||
const totalPopSpan = document.querySelector('span.total-population'); | ||
const averagePopSpan = document.querySelector('span.average-population'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that there is an element with the class 'average-population' in the DOM. If this element does not exist, this line will result in a null reference error when trying to set the textContent.
No description provided.