Task solution #2827
Open
Task solution #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2023 18:29
Viktor-Kost
suggested changes
Oct 3, 2023
| @@ -7,7 +7,43 @@ | |||
| * @return {Object[]} | |||
| */ | |||
| function transformStateWithClones(state, actions) { | |||
| // write code here | |||
| const statesArray = []; | |||
There was a problem hiding this comment.
Suggested change
| const statesArray = []; | |
| const statesArray = []; | |
| const stateCopy = { ...state }; |
src/transformStateWithClones.js
Outdated
| // write code here | ||
| const statesArray = []; | ||
|
|
||
| for (let i = 0; i < actions.length; i++) { |
There was a problem hiding this comment.
you can just use for of
Suggested change
| for (let i = 0; i < actions.length; i++) { | |
| for (const action of actions)) { |
src/transformStateWithClones.js
Outdated
| const statesArray = []; | ||
|
|
||
| for (let i = 0; i < actions.length; i++) { | ||
| switch (actions[i].type) { |
There was a problem hiding this comment.
Suggested change
| switch (actions[i].type) { | |
| switch (action.type) { |
src/transformStateWithClones.js
Outdated
Comment on lines
15
to
19
| const currentState = i ? { ...statesArray[i - 1] } : { ...state }; | ||
|
|
||
| Object.assign(currentState, actions[i].extraData); | ||
| statesArray.push(currentState); | ||
| break; |
There was a problem hiding this comment.
- no needs to update state at each case
- no needs to push updates at each case
- apply similar solution to cases below
Suggested change
| const currentState = i ? { ...statesArray[i - 1] } : { ...state }; | |
| Object.assign(currentState, actions[i].extraData); | |
| statesArray.push(currentState); | |
| break; | |
| Object.assign(stateCopy, action.extraData); | |
| break; |
| } | ||
|
|
||
| default: throw new Error('Invalid action type'); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| statesArray.push({ ...stateCopy }); |
|
Fixed |
volodymyr-soltys97
suggested changes
Oct 4, 2023
src/transformStateWithClones.js
Outdated
Comment on lines
13
to
14
| for (const action of actions) { | ||
| switch (action.type) { |
There was a problem hiding this comment.
Try to use a destruction for action
Suggested change
| for (const action of actions) { | |
| switch (action.type) { | |
| for (const action of actions) { | |
| const { type, ....... } = action; | |
| switch (type) { |
src/transformStateWithClones.js
Outdated
|
|
||
| for (const action of actions) { | ||
| switch (action.type) { | ||
| case 'addProperties': { |
There was a problem hiding this comment.
Consider will be better if you create a variables for these words and use them everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.