implemented task #2828
Open
implemented task #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Oct 4, 2023
src/transformStateWithClones.js
Outdated
Comment on lines
13
to
14
| for (const object of actions) { | ||
| if (object.type === 'addProperties') { |
There was a problem hiding this comment.
Use a destruction for object and try to use a switch instead of if/else if
etojeDenys
suggested changes
Oct 5, 2023
src/transformStateWithClones.js
Outdated
| @@ -7,7 +7,35 @@ | |||
| * @return {Object[]} | |||
| */ | |||
| function transformStateWithClones(state, actions) { | |||
| // write code here | |||
| const stateClone = { ...state }; | |||
There was a problem hiding this comment.
Suggested change
| const stateClone = { ...state }; | |
| let stateClone = { ...state }; |
src/transformStateWithClones.js
Outdated
Comment on lines
29
to
32
| case 'clear': | ||
| for (const key in stateClone) { | ||
| delete stateClone[key]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| case 'clear': | |
| for (const key in stateClone) { | |
| delete stateClone[key]; | |
| } | |
| case 'clear': | |
| stateClone = {}; |
src/transformStateWithClones.js
Outdated
Comment on lines
16
to
32
| switch (type) { | ||
| case 'addProperties': | ||
| Object.assign(stateClone, extraData); | ||
|
|
||
| stateVersions.push({ ...stateClone }); | ||
| break; | ||
| case 'removeProperties': | ||
| for (const toRemove of keysToRemove) { | ||
| delete stateClone[toRemove]; | ||
| } | ||
|
|
||
| stateVersions.push({ ...stateClone }); | ||
| break; | ||
| case 'clear': | ||
| for (const key in stateClone) { | ||
| delete stateClone[key]; | ||
| } |
There was a problem hiding this comment.
we can push only one time at the end of the loop
VitaliyBodnar
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.