Stateful-clones #2855
Open
Stateful-clones #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Oct 13, 2023
src/transformStateWithClones.js
Outdated
Comment on lines
18
to
28
| if (type === 'addProperties') { | ||
| for (const key in extraData) { | ||
| newState[key] = extraData[key]; | ||
| } | ||
| } else if (type === 'removeProperties') { | ||
| for (const key of keysToRemove) { | ||
| delete newState[key]; | ||
| } | ||
| } else if (type === 'clear') { | ||
| newState = {}; | ||
| } |
There was a problem hiding this comment.
- is better to use switch case statement if instead of multiple if blocks
- move addProperties, removeProperties, clear to the constants as it will make a code cleaner
src/transformStateWithClones.js
Outdated
|
|
||
| result.push(newState); | ||
|
|
||
| currentState = newState; |
There was a problem hiding this comment.
don't need to reassign currentState
Suggested change
| currentState = newState; |
src/transformStateWithClones.js
Outdated
| for (const action of actions) { | ||
| const { type, extraData, keysToRemove } = action; | ||
|
|
||
| let newState = { ...currentState }; |
There was a problem hiding this comment.
newState variables it redundant, because you can directly push copy of state to result
result.push({ ...currentState })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.