Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2865

Closed
wants to merge 1 commit into from
Closed

Solution #2865

wants to merge 1 commit into from

Conversation

Neison32
Copy link

No description provided.

}

function transformStateWithClones(state, actions) {
const stateHistory = [cloneObject(state)];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const stateHistory = [cloneObject(state)];
const stateHistory = [];

and we can remove the slice at all

Comment on lines +19 to +32

if (action.type === 'addProperties') {
// Add properties to the state
Object.assign(newState, action.extraData);
} else if (action.type === 'removeProperties') {
// Remove specified properties from the state
for (const key of action.keysToRemove) {
delete newState[key];
}
} else if (action.type === 'clear') {
// Create an empty state
newState = {};
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use switch case instead of the multiple if else

@Neison32 Neison32 closed this by deleting the head repository Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants