Solution #4094
Solution #4094
Conversation
There was a problem hiding this comment.
Your implementation is almost there, but there are a couple of critical issues that need to be addressed to meet the task requirements. Firstly, ensure that the states.push(currentState); statement is placed outside of the switch block to correctly record the state after processing all actions. Secondly, correct the error message in the default case to use backticks for proper template literal syntax. Once these are fixed, your solution will be in great shape! Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/transformStateWithClones.js
Outdated
| }); | ||
| break; | ||
| default: | ||
| throw new Error('Unknown action Type: ${action.type}'); |
There was a problem hiding this comment.
The error message uses template literals incorrectly. It should be throw new Error(Unknown action Type: ${action.type}); with backticks instead of single quotes.
src/transformStateWithClones.js
Outdated
| currentState = { ...currentState, ...action.extraData }; | ||
| break; | ||
| case 'removeProperties': | ||
| currentState = { ...currentState }; |
There was a problem hiding this comment.
This line is unnecessary as you are just re-creating the object as it already is
src/transformStateWithClones.js
Outdated
| }); | ||
| break; | ||
| default: | ||
| throw new Error('Unknown action Type: ${action.type}'); |
There was a problem hiding this comment.
For this to work, instead of single quotes, you should use backtick " ` ", if not, it will literally write ${action.type} and not it's value
| }); | ||
| break; | ||
| default: | ||
| throw new Error(`Unknown action Type: ${action.type}`); |
| const states = []; | ||
| let currentState = { ...state }; | ||
|
|
||
| actions.forEach(action => { |
There was a problem hiding this comment.
This task requires 3 methods:
'clear', 'addProperties', 'removeProperties'
You wrote just two:
'clear', 'addProperties'
Pay attention on the properties names, as addproperties is different than addProperties
| case 'clear': | ||
| currentState = {}; | ||
| break; | ||
| case 'addproperties': |
There was a problem hiding this comment.
this is not the addproperties, but the removeProperties
case 'removeProperties':
currentState = { ...currentState };
action.keysToRemove.forEach((key) => {
delete currentState[key];
});
break;
default:
No description provided.