-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #3678
base: master
Are you sure you want to change the base?
solution #3678
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +0,0 @@ | ||
module.exports = { | ||
extends: '@mate-academy/eslint-config', | ||
env: { | ||
jest: true | ||
}, | ||
rules: { | ||
'no-proto': 0 | ||
}, | ||
plugins: ['jest'] | ||
}; | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,24 @@ | |
* @return {object} | ||
*/ | ||
function convertToObject(sourceString) { | ||
// write your code here | ||
const result = {}; | ||
const rules = sourceString.split(';'); | ||
|
||
rules.forEach((rule) => { | ||
const clearRule = rule.trim(); | ||
|
||
if (clearRule) { | ||
const parts = clearRule.split(':'); | ||
const key = parts[0].trim(); | ||
const value = parts.length > 1 ? parts.slice(1).join(':').trim() : ''; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current implementation assumes that the value is everything after the first colon. This could lead to unexpected behavior if the value itself contains colons. Consider whether this behavior is intended and if not, adjust the logic to handle such cases appropriately. |
||
|
||
if (key) { | ||
result[key] = value; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the key is not an empty string before assigning it to the result object. The current check only ensures that |
||
} | ||
} | ||
}); | ||
|
||
return result; | ||
} | ||
|
||
module.exports = convertToObject; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use
reduce
to generate an object