Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #3678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,10 +0,0 @@
module.exports = {
extends: '@mate-academy/eslint-config',
env: {
jest: true
},
rules: {
'no-proto': 0
},
plugins: ['jest']
};
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^1.9.12",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
19 changes: 18 additions & 1 deletion src/convertToObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,24 @@
* @return {object}
*/
function convertToObject(sourceString) {
// write your code here
const result = {};
const rules = sourceString.split(';');

rules.forEach((rule) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use reduce to generate an object

const clearRule = rule.trim();

if (clearRule) {
const parts = clearRule.split(':');
const key = parts[0].trim();
const value = parts.length > 1 ? parts.slice(1).join(':').trim() : '';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation assumes that the value is everything after the first colon. This could lead to unexpected behavior if the value itself contains colons. Consider whether this behavior is intended and if not, adjust the logic to handle such cases appropriately.


if (key) {
result[key] = value;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the key is not an empty string before assigning it to the result object. The current check only ensures that key is truthy, which might not be sufficient if the input string contains keys that are just whitespace.

}
}
});

return result;
}

module.exports = convertToObject;
Loading