Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #3744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #3744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/convertToObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,19 @@
*
* @return {object}
*/
function convertToObject(sourceString) {
// write your code here
function convertToObject(styles) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function parameter is named styles, but the JSDoc comment refers to it as sourceString. Ensure consistency between the parameter name and the JSDoc comment.

const styleObject = {};
const declarations = styles.split(';');

declarations.forEach((declaration) => {
const [property, value] = declaration.split(':');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When splitting the declaration by ':', there might be cases where the value itself contains colons (e.g., URLs). Consider using a more robust parsing method to handle such cases.


if (property && value) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition if (property && value) checks for the existence of both property and value, but it does not account for cases where property or value might be whitespace. Consider trimming property and value before this check.

styleObject[property.trim()] = value.trim();
}
});

return styleObject;
}

module.exports = convertToObject;