Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solution #3746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: solution #3746

wants to merge 1 commit into from

Conversation

mtereshyn
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the convertToObject function! 🎉 Your code meets the task requirements and constraints effectively. While there was a minor logical error in checking if both key and value are present, it doesn't significantly impact the overall functionality. Remember to use if (key && value) for accurate checks in the future. Keep up the good work and continue improving your coding skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

splitString.forEach((element) => {
const [key, value] = element.split(':').map((item) => item && item.trim());

if ((key, value)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition (key, value) is incorrect for checking if both key and value are present. This condition always evaluates to true because it uses the comma operator, which returns the last operand. Instead, use if (key && value) to properly check if both key and value are non-empty strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants