Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #3759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #3759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/convertToObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,21 @@
* @return {object}
*/
function convertToObject(sourceString) {
// write your code here
const res = {};

const estilos = sourceString.split(';').filter(checkEmpty);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split(';') method is used correctly to separate the string into parts. However, ensure that the input string format is always consistent with this expectation, as any deviation might cause unexpected results.


estilos.forEach((estilo) => {
const [key, value] = estilo.split(':');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split(':') method assumes that each style definition contains exactly one colon. If the input string might contain multiple colons in a single style definition, this could lead to incorrect parsing. Consider handling such cases if applicable.


res[key.trim()] = value.trim();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trim() method is used correctly to remove any leading or trailing whitespace from the keys and values. This ensures that the resulting object does not contain any extraneous spaces.

});

return res;
}

function checkEmpty(linha) {
return linha.trim() !== '';
}

module.exports = convertToObject;
Loading