Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #3788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^1.9.12",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
52 changes: 51 additions & 1 deletion src/convertToObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,57 @@
* @return {object}
*/
function convertToObject(sourceString) {
// write your code here
const splittedString = sourceString

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name splittedString is not ideal. Consider renaming it to splitString for better readability.

.split(';')
.map((str) => str.trim())
.filter(Boolean);

const convertedToObject = {};

splittedString.forEach((str) => {
const styleArr = str.split(':');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split(':') method will not handle cases where there are multiple colons within a style value. Although handling multiple colons is not required, be aware that this could lead to unexpected behavior if such cases are encountered.

const [key, value] = styleArr;

convertedToObject[key.trim()] = value.trim();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that both key and value are defined before attempting to trim and assign them to the convertedToObject. If styleArr does not contain exactly two elements, this could lead to undefined behavior.

});

return convertedToObject;
}

module.exports = convertToObject;

convertToObject(`
background-color: #fff;
-webkit-border-radius: 5px;
border-radius : 5px;
border: 1px solid #e8e8e8;
-webkit-box-sizing: border-box;
box-sizing: border-box;
clear : both ;
cursor: pointer;
float: left;
font-family: inherit;
font-size: 14px;
font-weight: 400;
height: 42px;
line-height: 40px;
outline: 0;
padding-left : 18px;
padding-right: 30px;
;

;
position: relative;


text-align: left !important;
-webkit-transition: all .2s ease-in-out;
transition: all .2s ease-in-out;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;


white-space: nowrap;
width: auto;
`);
Loading