Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

renatoveludo
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the convertToObject function! 🎉 Your solution effectively meets the task requirements by converting CSS style strings into objects and using iteration methods appropriately. While there is a minor issue with handling empty declarations, your code is robust and well-structured.

For future improvements, consider trimming the sourceString to handle any leading or trailing semicolons that might result in empty declarations. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

const styleObject = {};

// Dividir a string em declarações separadas por ';'
const declarations = sourceString.split(';');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider trimming the sourceString before splitting it to handle any leading or trailing semicolons that might result in empty declarations.


declarations.forEach((declaration) => {
// Dividir cada declaração em chave e valor
const [property, value] = declaration.split(':').map((part) => part.trim());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation does not handle cases where there are multiple colons within a property value, which is acceptable as per the task requirements. However, ensure that this is the intended behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants