Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #3793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #3793

wants to merge 1 commit into from

Conversation

Vitalii120296
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the convertToObject function! 🎉 Your solution meets all the task requirements and constraints, and it effectively converts a style string into an object. While your code is correct, consider adding a check to handle empty segments or malformed key-value pairs gracefully. This will make your code more robust and prevent any invalid entries. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +12 to +16
styleArr.forEach((style) => {
const [key, value] = style.split(':').map((s) => s.trim());

styleObj[key] = value;
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure that both key and value are not undefined or empty. This will prevent adding invalid entries to the styleObj when the style string contains empty segments or malformed key-value pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants