Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete task #1245

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

complete task #1245

wants to merge 4 commits into from

Conversation

RomanMartseniuk
Copy link

SanyaBratashchuk
SanyaBratashchuk suggested changes Sep 12, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate different words with spaces
image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 13, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the demo link still not fixed from the previous review
image

@RomanMartseniuk
Copy link
Author

image

@RomanMartseniuk
Copy link
Author

image

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 16, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Your inputs are not clickable on the deploy. Consider fixing it

lerastarynets
lerastarynets suggested changes Sep 16, 2024
View reviewed changes
Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done
Pls try to pass all tests, if your tests pass locally, but you encounter a problem in server tests, pls attach a screen of all local tests passing

@RomanMartseniuk
Copy link
Author

image

anastasiiavorobiova
anastasiiavorobiova approved these changes Sep 16, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@lerastarynets lerastarynets Awaiting requested review from lerastarynets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RomanMartseniuk @volodymyr-soltys97 @lerastarynets @SanyaBratashchuk @anastasiiavorobiova