Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1247

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #1247

wants to merge 3 commits into from

Conversation

Grifion
Copy link

@Grifion Grifion commented Sep 12, 2024 •
edited
Loading

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 12, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. You need to fix all failed tests, if you need help feel free in the fe_chat
image
  1. You need to separate these words with a space
image

@Grifion
Copy link
Author

Grifion commented Sep 13, 2024

I have some problems with nmp in this assignment, but I think everything is already done so you can accept it, if you think it is not, just let me know and I will try to solve it again.

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 13, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this comment still not fixed, if you need help feel free in the fe_chat
image

Also, need to fix the failed tests

volodymyr-soltys97
volodymyr-soltys97 approved these changes Sep 13, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grifion @volodymyr-soltys97