Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1267

wants to merge 3 commits into from

Conversation

kovaltar
Copy link

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, your project is not reachable via the demo link(

@kovaltar
Copy link
Author

Unfortunately, your project is not reachable via the demo link(

Fixed

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
You need to separate these words with a space
image

@kovaltar
Copy link
Author

Good job 👍 Let's improve your code You need to separate these words with a space image

Done!

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done
Pls try to pass all tests, if your tests pass locally, but you encounter a problem in server tests, pls attach a screen of all local tests passing
Pls ask for help in fe_chat if you don't understand something

@kovaltar
Copy link
Author

kovaltar commented Sep 30, 2024

Well done Pls try to pass all tests, if your tests pass locally, but you encounter a problem in server tests, pls attach a screen of all local tests passing Pls ask for help in fe_chat if you don't understand something

I've no idea why tests didn't pass. When I try to run
npm test
i get
image
Tests didn't opened in browser. It seems like there is some problem with the tests in the platform side. Everything works locally, there are no errors, visually the result is reached.

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants