add task solution #903
Open
add task solution #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luk2asz
commented
Jul 18, 2023
Luk2asz
commented
- DEMO LINK
DorotaLeniecDev
suggested changes
Jul 20, 2023
src/scripts/main.js
Outdated
| label.setAttribute('for', input.getAttribute('id')); | ||
| label.textContent = input.getAttribute('name'); | ||
|
|
||
| let placeholder = label.textContent.charAt(0).toUpperCase(); |
There was a problem hiding this comment.
You could write:
Suggested change
| let placeholder = label.textContent.charAt(0).toUpperCase(); | |
| const placeholder = input.name[0].toUpperCase() + input.name.slice(1) |
src/scripts/main.js
Outdated
| const inputs = document.querySelectorAll('input'); | ||
|
|
||
| for (let i = 0; i < inputs.length; i++) { | ||
| document.createElement('label'); |
There was a problem hiding this comment.
Do you need this line? remove it if it is not used
DorotaLeniecDev
suggested changes
Jul 25, 2023
src/scripts/main.js
Outdated
| label.setAttribute('for', input.getAttribute('id')); | ||
| label.textContent = input.getAttribute('name'); | ||
|
|
||
| // let placeholder = label.textContent.charAt(0).toUpperCase(); |
src/scripts/main.js
Outdated
| // let placeholder = label.textContent.charAt(0).toUpperCase(); | ||
| const placeholder = input.name[0].toUpperCase() + input.name.slice(1); | ||
|
|
||
| // placeholder += label.textContent.slice(1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.