Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #927

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #927

wants to merge 3 commits into from

Conversation

Patryk-Buczkowski
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 3, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Need to add the space between these words
image
must be first name likewise and similarly other words

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 3, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
Also, add a space to the placeholder text here
image

volodymyr-soltys97
volodymyr-soltys97 approved these changes Nov 3, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🔥

src/scripts/main.js
Comment on lines +5 to +8
function capitalize(string) {
return (string.slice(0, 1).toUpperCase() + string.slice(1))
.replace(/([A-Z])/g, ' $1').trim();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution with a helper function 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patryk-Buczkowski @volodymyr-soltys97