Solution to review #1

SobchukSasha · 2022-10-04T14:22:36Z

Review

SobchukSasha · 2022-10-04T14:32:09Z

src/index.html

@@ -7,6 +7,308 @@
    <link rel="stylesheet" href="./styles/main.scss">
  </head>
  <body>
-    <h1>Catalog</h1>
+    <header class="header">
+


Unnecessary empty string

SobchukSasha · 2022-10-04T14:32:23Z

src/index.html

+    <header class="header">
+
+      <div class="header__logo"></div>
+


Unnecessary empty string

SobchukSasha · 2022-10-04T14:36:37Z

src/index.html

+      <div class="header__logo"></div>
+
+      <nav class="navigation">
+        <ul class="navigation__items-list">


unnecessary empty string

SobchukSasha · 2022-10-04T14:41:27Z

src/index.html

+
+      <nav class="navigation">
+        <ul class="navigation__items-list">
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:44:22Z

src/index.html

+      <nav class="navigation">
+        <ul class="navigation__items-list">
+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link is-active">Apple</a>


Use a '--' for modifier instead whitespace

SobchukSasha · 2022-10-04T14:44:37Z

src/index.html

+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link is-active">Apple</a>
+          </li>
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:44:44Z

src/index.html

+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link">Samsung</a>
+          </li>
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:46:19Z

src/index.html

+            <a href="#" class="navigation__link is-active">Apple</a>
+          </li>
+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link">Samsung</a>


Use new line for attributes

SobchukSasha · 2022-10-04T14:46:35Z

src/index.html

+            <a href="#" class="navigation__link">Samsung</a>
+          </li>
+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link">Смартфоны и телефоны</a>


Use new line for multiply attributes

SobchukSasha · 2022-10-04T14:46:51Z

src/index.html

+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link">Смартфоны и телефоны</a>
+          </li>
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:47:46Z

src/index.html

+            <a href="#" class="navigation__link">Смартфоны и телефоны</a>
+          </li>
+          <li class="navigation__items-list__item">
+            <a href="#"


Each attribute must be on a new line

SobchukSasha · 2022-10-04T14:48:27Z

src/index.html

+            Ноутбуки и компьютеры
+            </a>
+          </li>
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:48:49Z

src/index.html

+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link">Гаджеты</a>
+          </li>
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:49:18Z

src/index.html

+          <li class="navigation__items-list__item">
+            <a href="#" class="navigation__link">Планшеты</a>
+          </li>
+          <li class="navigation__items-list__item">


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-04T14:50:22Z

src/index.html

+          <li class="navigation__items-list__item">
+            <a href="#"
+              class="navigation__link"
+              data-qa="nav-hover">


Closing bracket must be on the new line

SobchukSasha · 2022-10-04T15:28:26Z

src/styles/card.scss

+  &__stars--2 .stars__star:nth-child(-n+2),
+  &__stars--3 .stars__star:nth-child(-n+3),
+  &__stars--4 .stars__star:nth-child(-n+4),
+  &__stars--5 .stars__star:nth-child(-n+5) {


Unnecessary nesting

SobchukSasha · 2022-10-04T15:29:40Z

src/styles/card.scss

+    align-items: flex-end;
+    justify-content: space-between;
+
+    &__word {


Here and below element in element - bad practice

SobchukSasha · 2022-10-04T15:30:18Z

src/styles/card.scss

+    width: 170px;
+    height: 40px;
+    margin-top: 20px;
+


Unneccessary empty line

SobchukSasha · 2022-10-04T15:30:21Z

src/styles/card.scss

+    border: 1px solid #00acdc;
+    border-radius: 5px;
+    background-color: #00acdc;
+


Unneccessary empty line

SobchukSasha · 2022-10-04T15:31:36Z

src/styles/header.scss

+    width: 40px;
+    height: 40px;
+    left: 50px;
+


Unneccessary empty line

SobchukSasha · 2022-10-05T07:08:56Z

src/index.html

+      <div class="card card--location" data-qa="card">
+        <img src="images/imac.jpeg"
+          alt="imac"
+          class="card__photo">


Closing bracket must be on the new line in this case. Use new line for multiply attributes.

SobchukSasha · 2022-10-05T07:11:14Z

src/index.html

+        </a>
+      </div>
+
+      <div class="card card--location" data-qa="card">


Only for the first card data-qa="card". Use new line for multiply attributes.
Card is block and location is element in this case.

SobchukSasha · 2022-10-05T07:11:22Z

src/index.html

+        </a>
+      </div>
+
+      <div class="card card--location" data-qa="card">


Only for the first card data-qa="card". Use new line for multiply attributes.
Card is block and location is element in this case.

SobchukSasha · 2022-10-05T07:11:28Z

src/index.html

+        </a>
+      </div>
+
+      <div class="card card--location" data-qa="card">


Only for the first card data-qa="card". Use new line for multiply attributes.
Card is block and location is element in this case.

SobchukSasha · 2022-10-05T07:11:32Z

src/index.html

+        </a>
+      </div>
+
+      <div class="card card--location" data-qa="card">


Only for the first card data-qa="card". Use new line for multiply attributes.
Card is block and location is element in this case.

SobchukSasha · 2022-10-05T07:11:37Z

src/index.html

+        </a>
+      </div>
+
+      <div class="card card--location" data-qa="card">


Only for the first card data-qa="card". Use new line for multiply attributes.
Card is block and location is element in this case.

SobchukSasha · 2022-10-05T07:21:00Z

src/index.html

+
+        <div class="card__price">
+          <p class="card__price__word">Цена:</p>
+          <p class="card__price__value">69 999 грн</p>


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-05T07:21:05Z

src/index.html

+
+        <div class="card__price">
+          <p class="card__price__word">Цена:</p>
+          <p class="card__price__value">69 999 грн</p>


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-05T07:21:09Z

src/index.html

+
+        <div class="card__price">
+          <p class="card__price__word">Цена:</p>
+          <p class="card__price__value">69 999 грн</p>


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-05T07:21:13Z

src/index.html

+
+        <div class="card__price">
+          <p class="card__price__word">Цена:</p>
+          <p class="card__price__value">69 999 грн</p>


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

SobchukSasha · 2022-10-05T07:21:17Z

src/index.html

+
+        <div class="card__price">
+          <p class="card__price__word">Цена:</p>
+          <p class="card__price__value">69 999 грн</p>


An element is always part of a block, not a second element. This means that the block__elem1__elem2 hierarchy cannot be written in the name of the elements.

Artem2427

Reviewed

Feature/solution_to_review_update

ArtemTopolskyi added 2 commits August 8, 2022 17:30

added task solution

b4b38e3

fix formatting

9771251

SobchukSasha commented Oct 4, 2022

View reviewed changes

src/index.html

<header class="header">

<div class="header__logo"></div>

Copy link

Author

SobchukSasha Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary empty string

SobchukSasha commented Oct 4, 2022

View reviewed changes

SobchukSasha commented Oct 5, 2022

View reviewed changes

Artem2427 reviewed Nov 22, 2022

View reviewed changes

mgrinko and others added 4 commits January 17, 2024 09:24

translate to EN

b805732

feature/solution_to_review_update updated solution related to master

5d11674

feature/solution_to_review_update reverted html changes

a844c45

Merge pull request #3 from mykhalenych/feature/solution_to_review_update

4966f3a

Feature/solution_to_review_update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solution to review #1

Solution to review #1

SobchukSasha commented Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022 •

edited

Loading

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 4, 2022

SobchukSasha Oct 5, 2022 •

edited

Loading

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

SobchukSasha Oct 5, 2022

Artem2427 left a comment

Solution to review #1

Are you sure you want to change the base?

Solution to review #1

Conversation

SobchukSasha commented Oct 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SobchukSasha Oct 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SobchukSasha Oct 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Artem2427 left a comment

Choose a reason for hiding this comment

SobchukSasha Oct 4, 2022 •

edited

Loading

SobchukSasha Oct 5, 2022 •

edited

Loading