Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4842

Closed
wants to merge 10 commits into from
Closed

Develop #4842

wants to merge 10 commits into from

Conversation

lopatkinss
Copy link

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • All component follow BEM and use SCSS
  • repaeted sizes and special colors are put to variables
  • Grid is used for the columns
  • cards are shown in 1, 2, 3 or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed to fully meet the task requirements. Here are the key points to focus on:

  1. BEM and SCSS Usage: Ensure that your HTML structure fully adheres to BEM conventions. Also, make sure that data-qa attributes are correctly applied as per the task requirements.

  2. Data-qa Attributes: Update the data-qa attributes to match the task specifications. Specifically, data-qa="nav-hover" should be on the 4th nav link, and data-qa="card-hover" should be on the 'Buy' button in the first card.

  3. Responsive Grid Layout: Implement media queries in your SCSS to adjust the grid layout for different screen sizes, as the task requires a responsive design.

  4. Hover Effects: Adjust the hover effects to match the specified colors and transitions in the task requirements.

  5. CSS Variables: Ensure all repeated sizes and colors are extracted into CSS variables for better maintainability.

  6. HTML Structure: Use a <main> tag for the cards container as specified in the task.

Once these issues are resolved, your implementation will be much stronger. Keep up the great work, and I'm confident you'll nail it! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines +23 to +24
padding: 0 50px;
padding-inline: 50px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding property is defined twice for the .header class. You can remove one of them to avoid redundancy. Consider keeping only padding-inline: 50px; if you want to apply padding to the left and right sides.

<ul class="nav__list">
<li class="nav__item">
<a
href="##"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute value '##' is not a valid URL. Consider using '#' for a placeholder or providing a valid URL.

@lopatkinss lopatkinss closed this by deleting the head repository Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants