Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4843

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30a25a
add task solution
Olifan Nov 12, 2024
f178fa2
fix task solution
Olifan Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,8 +33,8 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://olifan.github.io/layout_catalog/)
- [TEST REPORT LINK](https://olifan.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
357 changes: 356 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,361 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<div class="header__logo logo">
<a
href="#"
class="logo__link"
>
<img
src="./images/logo.png"
alt="Logo"
/>
</a>
</div>
<nav class="nav">
<ul class="nav__list">
<li class="nav__list-item">
<a
href="#"
class="is-active"
>
Apple
</a>
</li>
<li class="nav__list-item">
<a href="#">Samsung</a>
</li>
<li class="nav__list-item">
<a href="#">Smartphones</a>
</li>
<li class="nav__list-item">
<a
href="#"
data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>
<li class="nav__list-item">
<a href="#">Gadgets</a>
</li>
<li class="nav__list-item">
<a href="#">Tablets</a>
</li>
<li class="nav__list-item">
<a href="#">Photo</a>
</li>
<li class="nav__list-item">
<a href="#">Video</a>
</li>
</ul>
</nav>
</header>

<main class="catalog">
<div
class="card"
data-qa="card"
>
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the link provided in the href attribute is correct and accessible. If this is a placeholder, consider updating it to a valid URL.

class="card__button"
data-qa="hover"
>
<div class="card__button-text">BUY</div>
</a>
</div>
<div
class="card"
data-qa="card"
>
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute contains a link that should be verified for correctness and accessibility. If it's a placeholder, replace it with a valid URL.

class="card__button"
data-qa="card-hover"
>
<div class="card__button-text">BUY</div>
</a>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the href attribute for a valid URL. If this is a placeholder, update it to a correct link.

class="card__button"
>
<div class="card__button-text">BUY</div>
</a>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the href attribute contains a valid URL. If this is a placeholder, replace it with a correct link.

class="card__button"
>
<div class="card__button-text">BUY</div>
</a>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the href attribute contains a valid URL. If this is a placeholder, update it to a correct link.

class="card__button"
>
<div class="card__button-text">BUY</div>
</a>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the href attribute for a valid URL. If this is a placeholder, replace it with a correct link.

class="card__button"
>
<div class="card__button-text">BUY</div>
</a>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the href attribute contains a valid URL. If this is a placeholder, replace it with a correct link.

class="card__button"
>
<div class="card__button-text">BUY</div>
</a>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="iMac 27 Retina"
class="card__image"
/>

<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__code">Product code: 195434</div>

<div class="card__stars">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-text">Price:</div>
<div class="card__price-num">$2,199</div>
</div>

<a
href="https://mate-academy.github.io/layout_task-guideline/"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the href attribute contains a valid URL. If this is a placeholder, update it to a correct link.

class="card__button"
>
<div class="card__button-text">BUY</div>
</a>
</div>
</main>
</body>
</html>
Loading
Loading