Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready header for mobiles & tablets #974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ready header for mobiles & tablets #974

wants to merge 1 commit into from

Conversation

sborichevskyi
Copy link

DEMO LINK.
i've made the header for mobiles and tablets. I'd be glad to hear your recommendations. BTW, when i came across header on desktops, i understood, that header content (except top bar) should be displayed with grid, right?

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 21, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!
To improve:

  1. Add a favicon on the page
image
  1. Need to implement the burger menu when user is clicking on this icon
image
  1. Keep going with the next sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sborichevskyi @volodymyr-soltys97