Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEMO LINK #976

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

DEMO LINK #976

wants to merge 6 commits into from

Conversation

Anton777148
Copy link

anastasiia-tilikina
anastasiia-tilikina suggested changes Aug 21, 2024
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
There are some fixes needed

  1. add scroll-behaviour: smooth for your page
  2. add hover effects to these elements as well
    image

image

image

  1. Remove page scroll while mobile menu is open
  2. Add menu scroll to be able to see all its content when there is not enough height in landscape mode on small mobile

image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 23, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. The gap between these sections is too big, need to fix it
image
  1. Need to disable scroll when the burger menu is open
image

etojeDenys
etojeDenys suggested changes Aug 23, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your demo link doesn't work, try to run npm run deploy again

volodymyr-soltys97
volodymyr-soltys97 approved these changes Aug 24, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@anastasiia-tilikina anastasiia-tilikina Awaiting requested review from anastasiia-tilikina

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anton777148 @volodymyr-soltys97 @etojeDenys @anastasiia-tilikina