Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dia landing page #990

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dia landing page #990

wants to merge 4 commits into from
+2,069 −8

Conversation

VasylPylypchynets
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 29, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-09-29 at 16 20 20
Screenshot 2024-09-29 at 16 20 25
Check padding here
Screenshot 2024-09-29 at 16 20 00
Screenshot 2024-09-29 at 16 20 04
Check hovers here
Screenshot 2024-09-29 at 16 19 48
Screenshot 2024-09-29 at 16 19 53
Check the font style here
Screenshot 2024-09-29 at 16 18 36
Consider adding a bit more space between blocks

etojeDenys
etojeDenys suggested changes Sep 29, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks different on mobile
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VasylPylypchynets @etojeDenys @anastasiiavorobiova