Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #993

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Develop #993

wants to merge 14 commits into from

Conversation

AlbinaAlbi
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 4, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-10-04 at 17 08 13
Consider adding the menu functionality
Screenshot 2024-10-04 at 17 07 14
Check the layout here
Screenshot 2024-10-04 at 17 05 43
Consider adding a hover effect
Screenshot 2024-10-04 at 17 05 30
Consider opening these links in the new tab

SanyaBratashchuk
SanyaBratashchuk suggested changes Oct 6, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

VitaliyBondarenko1982
VitaliyBondarenko1982 suggested changes Oct 6, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Fix mobile menu

  • it shouldn't visible on desktop (also burger icon)
  • on mobile it not works
    Screenshot 2024-10-06 at 19 02 05

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Oct 6, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbinaAlbi @VitaliyBondarenko1982 @SanyaBratashchuk @anastasiiavorobiova