add task solution #3440
Open
add task solution #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyLiza
commented
Jul 25, 2023
LadyLiza
commented
- DEMO LINK
- TEST REPORT LINK
volodymyr-soltys97
suggested changes
Jul 25, 2023
src/index.html
Outdated
Comment on lines
14
to
18
| <form | ||
| class="search-bar big-form" | ||
| data-qa="big" | ||
| method="get" | ||
| action="/"> |
There was a problem hiding this comment.
Need to check and fix it everywhere
Suggested change
| <form | |
| class="search-bar big-form" | |
| data-qa="big" | |
| method="get" | |
| action="/"> | |
| <form | |
| class="search-bar big-form" | |
| data-qa="big" | |
| method="get" | |
| action="/" | |
| > |
src/style.css
Outdated
| margin: 20px 8px 0; | ||
| } | ||
|
|
||
| .search-bar input { |
There was a problem hiding this comment.
Need to write styles for input with classes selector
src/style.css
Outdated
| @font-face { | ||
| font-family: "Avenir Heavy"; | ||
| src: url("./fonts/Avenir-Heavy.ttf"); | ||
| font-style: normal; |
There was a problem hiding this comment.
Default value, you can just remove it
Suggested change
| font-style: normal; |
vlad-demchuk
suggested changes
Jul 28, 2023
src/style.css
Outdated
| margin: 20px 8px 0; | ||
| } | ||
|
|
||
| .search-bar .input { |
src/style.css
Outdated
| background-position: 25px center; | ||
| } | ||
|
|
||
| .small-form .input { |
anastasiiavorobiova
suggested changes
Jul 28, 2023
|
@anastasiiavorobiova Updated DEMO and TEST links. Could you please check it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.