add resolve for search bar #3444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denys-danyliuk
suggested changes
Jul 27, 2023
src/style.css
Outdated
Comment on lines
49
to
66
| .input--big { | ||
| height: 70px; | ||
| padding-left: 62px; | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| .search-form__input--big::before { | ||
| height: 19px; | ||
| width: 19px; | ||
| top: 25px; | ||
| left: 26px; | ||
| } | ||
|
|
||
| .input--sm { | ||
| height: 42px; | ||
| font-size: 14px; | ||
| padding-left: 33px; | ||
| } |
There was a problem hiding this comment.
2'nd point in checklist, create base class and one where you will override needed styles
src/index.html
Outdated
Comment on lines
19
to
37
| <form | ||
| action="#" | ||
| method="post" | ||
| data-qa="big" | ||
| class="search-form" | ||
| > | ||
|
|
||
| <div class="search-form__input search-form__input--big"> | ||
|
|
||
| <input | ||
| type="text" | ||
| class="input input--big " | ||
| data-qa="keypress" | ||
| placeholder="Try "Los Angeles"" | ||
| > | ||
|
|
||
| </div> | ||
|
|
||
| </form> |
There was a problem hiding this comment.
Suggested change
| <form | |
| action="#" | |
| method="post" | |
| data-qa="big" | |
| class="search-form" | |
| > | |
| <div class="search-form__input search-form__input--big"> | |
| <input | |
| type="text" | |
| class="input input--big " | |
| data-qa="keypress" | |
| placeholder="Try "Los Angeles"" | |
| > | |
| </div> | |
| </form> | |
| <form | |
| action="#" | |
| method="post" | |
| data-qa="big" | |
| class="search-form" | |
| > | |
| <div class="search-form__input search-form__input--big"> | |
| <input | |
| type="text" | |
| class="input input--big " | |
| data-qa="keypress" | |
| placeholder="Try "Los Angeles"" | |
| > | |
| </div> | |
| </form> |
src/index.html
Outdated
| class="search-form" | ||
| > | ||
|
|
||
| <div class="search-form__input search-form__input--big"> |
There was a problem hiding this comment.
do you really need this wrapper
src/index.html
Outdated
Comment on lines
28
to
33
| <input | ||
| type="text" | ||
| class="input input--big " | ||
| data-qa="keypress" | ||
| placeholder="Try "Los Angeles"" | ||
| > |
src/style.css
Outdated
Comment on lines
1
to
11
| @font-face { | ||
| font-family: Avenir-Book; | ||
| src: url(./fonts/Avenir-Book.ttf); | ||
| font-weight: 300; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: Avenir-Heavy; | ||
| src: url(./fonts/Avenir-Heavy.ttf); | ||
| font-weight: 700; | ||
| } |
denys-danyliuk
suggested changes
Jul 28, 2023
src/style.css
Outdated
Comment on lines
19
to
40
| .search-form::before { | ||
| content: ""; | ||
| position: absolute; | ||
| background-image: url("./images/Search.svg"); | ||
| background-position: center; | ||
| background-size: cover; | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .search-form--big::before { | ||
| height: 19px; | ||
| width: 19px; | ||
| top: 25px; | ||
| left: 26px; | ||
| } | ||
|
|
||
| .search-form--sm::before { | ||
| width: 11px; | ||
| height: 11px; | ||
| top: 15px; | ||
| left: 13px; | ||
| } |
src/style.css
Outdated
Comment on lines
42
to
68
| .input { | ||
| width: 100%; | ||
| box-sizing: border-box; | ||
| font-family: "Avenir-Book", Arial, sans-serif; | ||
| font-weight: 700; | ||
|
|
||
| border-radius: 4px; | ||
| border: 1px solid var(--border-color); | ||
| background: var(--background-color); | ||
| box-shadow: 0 1px 8px 0 rgba(61, 78, 97, 0.1); | ||
| } | ||
| /* if i*m wrong about fonts. I've confused in this - - Remember that inputs and | ||
| other interactive elements don’t inherit font styles by default. | ||
| - Remember that placeholder has its own set of styles available using ` | ||
| ::placeholder` pseudo-element. */ | ||
|
|
||
| .input--big { | ||
| height: 70px; | ||
| padding-left: 62px; | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| .input--sm { | ||
| height: 42px; | ||
| font-size: 14px; | ||
| padding-left: 33px; | ||
| } |
src/style.css
Outdated
Comment on lines
1
to
5
| @font-face { | ||
| font-family: Avenir-Book; | ||
| src: url(./fonts/Avenir-Book.ttf); | ||
| font-weight: 300; | ||
| } |
There was a problem hiding this comment.
you need to connect this font with other font-weight also, check the design
denys-danyliuk
approved these changes
Aug 1, 2023
Comment on lines
+46
to
48
| </form> | ||
|
|
||
| </body> |
There was a problem hiding this comment.
Suggested change
| </form> | |
| </body> | |
| </form> | |
| </body> |
don't add spaces between child and parent elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK