-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #3449
base: master
Are you sure you want to change the base?
add task solution #3449
Conversation
PodvAx
commented
Jul 27, 2023
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ! Just a few small fixes need to be done
src/index.html
Outdated
<img | ||
src="./images/Search.svg" | ||
alt="search-icon" | ||
class="input__icon input__icon--small" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5'th point in checklist
src/style.css
Outdated
} | ||
|
||
.input--small { | ||
/* width: 50%; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete comments
src/style.css
Outdated
|
||
.input:focus { | ||
border-radius: 3px; | ||
border: 1px solid #e1e7ed !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid using important, people get fired from work because of it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🔥