Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #3449

wants to merge 2 commits into from

Conversation

PodvAx
Copy link

@PodvAx PodvAx commented Jul 27, 2023

Copy link

@denys-danyliuk denys-danyliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Just a few small fixes need to be done

src/index.html Outdated
Comment on lines 48 to 52
<img
src="./images/Search.svg"
alt="search-icon"
class="input__icon input__icon--small"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5'th point in checklist

src/style.css Outdated
}

.input--small {
/* width: 50%; */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete comments

src/style.css Outdated

.input:focus {
border-radius: 3px;
border: 1px solid #e1e7ed !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid using important, people get fired from work because of it :)

Copy link

@xiimiik xiimiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants