Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #3936

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

alionazherdetska
Copy link

@alionazherdetska alionazherdetska commented Jan 5, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@Esceype Esceype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!
Read the following comments

<body>
<h1>Search bar airbnb</h1>
<body class="page">
<section class="searchbars">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don`t need this wrapper here, because you can use just margins and blocks without flex-container

src/index.html Outdated
<h1>Search bar airbnb</h1>
<body class="page">
<section class="searchbars">
<div class="searchbars searchbars__wide" data-qa="big">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be form not a div

src/style.css Outdated

&::placeholder {
font-weight: 300;
color: #3D4E61;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all your colors to variables and then reuse them

src/style.css Outdated
gap: 20px;
}

.searchbars[data-qa="big"] input {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use selectors by class, it's much better and fits better with the bem methodology for which it was created.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants