-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #3936
base: master
Are you sure you want to change the base?
Develop #3936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
Read the following comments
<body> | ||
<h1>Search bar airbnb</h1> | ||
<body class="page"> | ||
<section class="searchbars"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don`t need this wrapper here, because you can use just margins and blocks without flex-container
src/index.html
Outdated
<h1>Search bar airbnb</h1> | ||
<body class="page"> | ||
<section class="searchbars"> | ||
<div class="searchbars searchbars__wide" data-qa="big"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be form
not a div
src/style.css
Outdated
|
||
&::placeholder { | ||
font-weight: 300; | ||
color: #3D4E61; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move all your colors to variables and then reuse them
src/style.css
Outdated
gap: 20px; | ||
} | ||
|
||
.searchbars[data-qa="big"] input { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use selectors by class, it's much better and fits better with the bem methodology for which it was created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️