add task solution #4318
Open
add task solution #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
volodymyr-soltys97
suggested changes
Jun 3, 2024
src/index.html
Outdated
| data-qa="keypress" | ||
| placeholder="Try “Los Angeles“" | ||
| /> | ||
| <div class="search-bar"> |
There was a problem hiding this comment.
This div is redundant
Suggested change
| <div class="search-bar"> |
SanyaBratashchuk
suggested changes
Jun 3, 2024
src/style.css
Outdated
| * { | ||
| font-family: Avenir, Arial, Helvetica, sans-serif; | ||
| box-sizing: border-box; | ||
| font-weight: 300px; |
There was a problem hiding this comment.
Suggested change
| font-weight: 300px; | |
| font-weight: 300; |
| } | ||
|
|
||
| * { | ||
| font-family: Avenir, Arial, Helvetica, sans-serif; |
There was a problem hiding this comment.
it is better to set font-family for html tag selector and let other elements inherit it
src/style.css
Outdated
| width: 100%; | ||
| border: 1px solid #e1e7ed; | ||
| box-shadow: 0 1px 8px 0 rgba(61, 78, 97, 0.1); | ||
| line-height: 21.86px; |
There was a problem hiding this comment.
do not set decimal pixel values
src/style.css
Outdated
| .search-bar-input--down { | ||
| display: flex; | ||
| font-size: 14px; | ||
| border-radius: 5; |
There was a problem hiding this comment.
Suggested change
| border-radius: 5; | |
| border-radius: 5px; |
SanyaBratashchuk
approved these changes
Jun 3, 2024
src/style.css
Outdated
| width: 100%; | ||
| border: 1px solid #e1e7ed; | ||
| box-shadow: 0 1px 8px 0 rgba(61, 78, 97, 0.1); | ||
| font-family: Avenir, Arial, Helvetica, sans-serif; |
There was a problem hiding this comment.
Suggested change
| font-family: Avenir, Arial, Helvetica, sans-serif; | |
| font-family: inherit; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical MistakesfromBEMlesson theory are checked.