Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4318

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add task solution #4318

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
216202e
add task solution
Jun 2, 2024
2b49e64
add task solution
Jun 2, 2024
42d1e09
add task solution
Jun 3, 2024
a2d1146
add task solution
Jun 3, 2024
1420a1a
add task solution
Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ ___

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_search-bar-airbnb/report/html_report/)
- [DEMO LINK](https://tuhusova.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://tuhusova.github.io/layout_search-bar-airbnb/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

- [ ] Icon implemented using background-image CSS property
- [ ] Inputs are written inside of 'form' tag with correctly passed attributes
- [ ] All `Typical Mistakes` from `BEM` lesson theory are checked.
- [ ] Code follows all the [Code Style Rules ❗️](./checklist.md)
- [x] Icon implemented using background-image CSS property
- [x] Inputs are written inside of 'form' tag with correctly passed attributes
- [x] All `Typical Mistakes` from `BEM` lesson theory are checked.
- [x] Code follows all the [Code Style Rules ❗️](./checklist.md)
32 changes: 22 additions & 10 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,28 @@
/>
</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
<form
class="search-bar-top"
data-qa="big"
>
<input
class="search-bar-input search-bar-input--top"
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
</form>

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
<form
class="search-bar-down"
data-qa="small"
>
<input
class="search-bar-input search-bar-input--down"
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
</form>
</body>
</html>
66 changes: 65 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,65 @@
/* add styles here */
@font-face {
font-family: Avenir;
src: url('./fonts/Avenir-Book.ttf');
src: url('./fonts/Avenir-Heavy.ttf');
src: url('./fonts/Avenir.ttc');
font-style: normal;
font-weight: normal;
color: rgba(61, 78, 97, 1);
}

* {
font-family: Avenir, Arial, Helvetica, sans-serif;
box-sizing: border-box;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to set font-family for html tag selector and let other elements inherit it

font-weight: 300px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-weight: 300px;
font-weight: 300;


.search-bar-input {
margin: 20px 0;
box-sizing: border-box;
border-radius: 4px;
background-image: url(/src/images/Search.svg);
background-repeat: no-repeat;
width: 100%;
border: 1px solid #e1e7ed;
box-shadow: 0 1px 8px 0 rgba(61, 78, 97, 0.1);
line-height: 21.86px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not set decimal pixel values


.search-bar-input--top {
display: flex;
color: #3d4e61;
font-size: 16px;
height: 70px;
padding-left: 62px;
background-size: 19px 19px;
background-position: 26px center;
}

.search-bar-input--down {
display: flex;
font-size: 14px;
border-radius: 5;
height: 42px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-radius: 5;
border-radius: 5px;

padding-left: 33px;
background-size: 11px 11px;
background-position: 13px center;
}

.search-bar-input::placeholder {
color: #3d4e61;
}

.search-bar-input :hover {
box-shadow: 0 4px 4px 0;
color: rgba(0, 0, 0, 0.25);
}

.search-bar-input :focus {
box-shadow: 0 4px 4px 0;
color: rgba(0, 0, 0, 0.25);
font-size: 16px;
line-height: 21.86px;
text-align: left;
font-family: Avenir-Heavy, sans-serif;
}
Loading