Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #4326

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #4326

wants to merge 2 commits into from

Conversation

vkryvytskyy
Copy link

No description provided.

Comment on lines 2 to 4
<!doctype html>
<html lang="en">
<head>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <!doctype html> declaration must be the very first thing in an HTML document, before the tag.

Comment on lines +20 to +21
href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap"
rel="stylesheet"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL for the href attribute of the link tag seems to be missing. Ensure you provide the correct path to the stylesheet.

Comment on lines +20 to +22
href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap"
rel="stylesheet"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attributes within the tag should be ordered consistently. You should place 'rel' before 'href' for readability and consistency.

Comment on lines +26 to +42
<form class="form">
<div
class="form__search"
data-qa="big"
>
<label for="input-large"></label>
<img
class="form-img form__img--large"
src="images/Search.svg"
alt="Search"
/>
<input
class="form-input form__input--large"
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label element should have content that describes the input it is associated with, or you can use the aria-label attribute on the input for screen reader users.

class="form__search"
data-qa="big"
>
<label for="input-large"></label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute 'for' in the label should match the ID of the input it is related to, which is missing here.

Comment on lines +12 to +16
font-family: Avenir-Heavy, sans-serif;
src: url(fonts/Avenir-Heavy.ttf);
font-style: bold;
font-weight: bold;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-style and font-weight properties should not both be set to 'bold'. Instead, use font-weight: bold; or font-weight: 700; and remove the font-style: bold; declaration.

}

.form {
margin-top: auto;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The margin-top: auto; on the .form class does not seem to serve a purpose unless it is within a flex or grid context with specific alignments.


.form-input {
display: block;
margin: o;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the margin property value; it should be 0 instead of o.

color: rgba(255, 255, 255, 1);
border: 1px solid rgba(225, 231, 237, 1);
border-radius: 4px;
box-shadow: rgba(61, 78, 97, 0.1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The box-shadow property is missing horizontal and vertical offsets, and the blur radius. It should be something like box-shadow: 0 1px 4px rgba(61, 78, 97, 0.1);.

height: 42px;
margin-top: 20px;
padding-left: 33px; /* додаємо відступ, щоб текст не накладався на іконку */
size: 14px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size property is not a valid CSS property. If you meant to set the font size, use font-size instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants