Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Develop #4327

wants to merge 1 commit into from

Conversation

Anya-Laban
Copy link

Checklist to the Pull Request

  • Icon implemented using background-image CSS property
  • Inputs are written inside of 'form' tag with correctly passed attributes
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The placeholder shouldn't change on hover
image

Comment on lines +76 to +81
.form__input--small:focus {
font-family: Avenir-Heavy, sans-serif;
color: #3d4e61;
outline: none;
border: 1px solid #e1e7ed;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't repeat styles. Move them to the common class

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Якщо я змінюю колір placeholder лише при фокусі, то не проходить 2 тести. Я ж правильно розумію що Ваш коментар про placeholder стосується саме коліру?

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants