Develop #4352
Open
Develop #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Jun 28, 2024
Comment on lines
+28
to
+29
| - [DEMO LINK](https://Miranna472.github.io/layout_search-bar-airbnb/) | ||
| - [TEST REPORT LINK](https://Miranna472.github.io/layout_search-bar-airbnb/report/html_report/) |
There was a problem hiding this comment.
Add these links to the PR description
src/index.html
Outdated
| data-qa="hover" | ||
| placeholder="Try “Los Angeles“" | ||
| /> | ||
| <div class="search-bar-container"> |
There was a problem hiding this comment.
Redundant
Suggested change
| <div class="search-bar-container"> |
| } | ||
|
|
||
| body { | ||
| font-family: Avenir, Arial, Helvetica, sans-serif; |
There was a problem hiding this comment.
Move font styles to the html selector
There was a problem hiding this comment.
when I move everything to html, all the fonts fly off. That's why I left it as it was
src/style.css
Outdated
Comment on lines
28
to
33
| box-sizing: border-box; | ||
| font-size: 16px; | ||
| text-align: left; | ||
| font-weight: 300; | ||
| font-style: normal; | ||
| margin-top: 0; |
There was a problem hiding this comment.
Redundant
Suggested change
| box-sizing: border-box; | |
| font-size: 16px; | |
| text-align: left; | |
| font-weight: 300; | |
| font-style: normal; | |
| margin-top: 0; |
src/style.css
Outdated
| margin-top: 20px; | ||
| } | ||
|
|
||
| .search-bar.big input { |
There was a problem hiding this comment.
Use only class selector instead of input, fix it everywhere
src/style.css
Outdated
| .search-bar.big input:focus { | ||
| font-size: 16px; | ||
| font-weight: 900; | ||
| line-height: 21.86px; |
There was a problem hiding this comment.
Suggested change
| line-height: 21.86px; | |
| line-height: 22px; |
src/style.css
Outdated
| font-size: 16px; | ||
| font-weight: 900; | ||
| line-height: 21.86px; | ||
| text-align: left; |
There was a problem hiding this comment.
Default value, you can just remove it everywhere
Suggested change
| text-align: left; |
|
SanyaBratashchuk
approved these changes
Jul 1, 2024
|
|
||
| body { | ||
| font-family: Avenir, Arial, Helvetica, sans-serif; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
it is common practice to apply same box-sizing for all elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.