Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Serch bar #4379

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Dushkaaa-BabyBoss
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
Remove the default blue border and don't need to hide search icon when input is focused
image
image

src/style.css Outdated
font-size: 16px;
font-weight: normal;
color: #3d4e61;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove stylelint comments

Suggested change
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */

src/style.css Outdated
Comment on lines 83 to 84
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: Avenir-book;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add the generic family keywords

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: Avenir-book;
font-family: Avenir-book, sans-serif;

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're showing incredible skills, keep it going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants