DEVELOP #4383
DEVELOP #4383
Conversation
Yatsomo
commented
Jul 18, 2024
•
Yatsomo
commented
- DEMO LINK
- TEST REPORT LINK
|
The checks pass in VSC but fail on GitHub? How so? |
| color: #3d4e61; | ||
| } | ||
|
|
||
| .searchbar__big { |
|
|
||
| .searchbar__small { | ||
| height: 42px; | ||
| background-position: 12px 14px; |
There was a problem hiding this comment.
When its like that the test comes back negative. Should I still change it?
| data-qa="big" | ||
| > | ||
| <input | ||
| class="searchbar__input searchbar__big" |
There was a problem hiding this comment.
Its great case to use modifier class name like this searchbar__input searchbar__input--big
| <input | ||
| class="searchbar__input searchbar__big" | ||
| type="text" | ||
| name="searchbar__bar searchbar__big" |
There was a problem hiding this comment.
This is weird value for name property. It is primarily used in form elements to identify input fields when they are submitted to a server.
| } | ||
|
|
||
| .searchbar { | ||
| margin: 20px 0; |
There was a problem hiding this comment.
In this task its okay. But remember that if you want to configure the external geometry or positioning of a block, use separate classes or mix-ins to separate external properties (positioning, margins) from internal properties (padding). This approach helps avoid conflicts between element styles.
|
|
||
| .searchbar__small { | ||
| height: 42px; | ||
| background-position: 12px 14px; |
