Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add task solution #4386

wants to merge 3 commits into from

Conversation

IvanSierov
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Jul 19, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! The input should span the whole area
Screenshot 2024-07-19 at 16 53 49

src/style.css Outdated
}

form {
/* border: black 1px solid; */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* border: black 1px solid; */

src/style.css Outdated
display: flex;
}

[data-qa='big'] {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using classes as selectors

src/style.css Outdated
padding: 0;
}

[data-qa='keypress'] {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue here

@IvanSierov
Copy link
Author

form and input are both block elements and stretch to the full width of their parent element by default. I changed all the selectors, now they are all class selectors.

volodymyr-soltys97
volodymyr-soltys97 suggested changes Jul 20, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. This div is redundant, you need to add icon as background for the input
image
  1. The input should span the entire width of the page
image

vadiimvooo
vadiimvooo approved these changes Jul 21, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadiimvooo vadiimvooo vadiimvooo approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanSierov @volodymyr-soltys97 @vadiimvooo @anastasiiavorobiova