Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4396

wants to merge 2 commits into from

Conversation

labelsavchuk
Copy link

@labelsavchuk labelsavchuk reopened this Jul 27, 2024
polosanya
polosanya suggested changes Aug 7, 2024
View reviewed changes
Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's improve your solution a bit)
Placeholder shouldn't change on focus
image

src/index.html Outdated
<form data-qa="small">
<label class="search-bar search-bar--size--small page__search">
<input
class="search-bar__input search-bar__input--size--small"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class="search-bar__input search-bar__input--size--small"
class="search-bar__input search-bar__input--small"

Classnames can be simplified

src/style.css
.search-bar::after {
background-image: url(./images/Search.svg);
height: 19px;
position: absolute;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pay attention to CSS properties order
https://9elements.com/css-rule-order/

@labelsavchuk
Copy link
Author

@labelsavchuk labelsavchuk reopened this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polosanya polosanya polosanya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labelsavchuk @polosanya