Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task solution #4413

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have border radius only on focus and on focus search bars shouldn't have outline and bigger one need text-shadow

data-qa="big"
>
<label class="search-form__label search-form__label__big">
<!-- prettier-ignore -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore prettier?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because when I made "npm run lint", the placeholder change from "Try "Los Angeles"" into 'Try "Los Angeles" ' and i could not came through it. So I found a solution on internet and it works

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text-shadow should look different
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants