-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task solution #4413
base: master
Are you sure you want to change the base?
Task solution #4413
Conversation
MateuszCieplak
commented
Aug 6, 2024
- [DEMO LINK] (https://MateuszCieplak.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK] (https://MateuszCieplak.github.io/layout_search-bar-airbnb/report/html_report/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have border radius only on focus and on focus search bars shouldn't have outline and bigger one need text-shadow
data-qa="big" | ||
> | ||
<label class="search-form__label search-form__label__big"> | ||
<!-- prettier-ignore --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ignore prettier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because when I made "npm run lint", the placeholder change from "Try "Los Angeles"" into 'Try "Los Angeles" ' and i could not came through it. So I found a solution on internet and it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.