-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add index.html and style.css files #4419
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls, feel free to ask for some help with those quotes in the chat
I found this syntax way: placeholder="Try "Los Angeles"" but still I can't pass the test. |
I found syntax ways to solve it, as follows: placeholder="Try "Los Angeles"" and when I run this command -> 'npm run lint' the following syntax automatically changes to placeholder='Try "Los Angeles"' and in result test can't be passed. Sorry but its really wierd and I think that something is wrong while lint checks for errors following syntax code: placeholder="Try "Los Angeles"". So I had to use following syntax to at least push it: placeholder="Try 'Los Angeles'" |
I just updated value of attribute 'placeholder' in index.html. And it shows that tests are passed. Please check it and approve it. Thank you ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updates in placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your code
- [DEMO LINK](https://YevhenRDoIT.github.io/layout_search-bar-airbnb/) | ||
- [TEST REPORT LINK](https://YevhenRDoIT.github.io/layout_search-bar-airbnb/report/html_report/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-family: Avenir, sans-serif; | ||
font-size: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move font styles to the html selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting issue with placeholder value placeholder='Try "Los Angeles"'. So when I run command 'npm run lint' it doesn't pass this way because it asks for double qoutes around "Try "Los Angeles"" but this way it still doesn't pass. So i decided to do this way: placeholder="Try Los Angeles" and command 'npm run lint' passed it. But the command 'npm test' says that there are three fails because of no double qoutes around text "Los Angeles". Yes I also have tried this way: placeholder=
Try ${"Los Angeles"}
but it doesn't work here.