Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add index.html and style.css files #4419

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

YevhenRDoIT
Copy link

Interesting issue with placeholder value placeholder='Try "Los Angeles"'. So when I run command 'npm run lint' it doesn't pass this way because it asks for double qoutes around "Try "Los Angeles"" but this way it still doesn't pass. So i decided to do this way: placeholder="Try Los Angeles" and command 'npm run lint' passed it. But the command 'npm test' says that there are three fails because of no double qoutes around text "Los Angeles". Yes I also have tried this way: placeholder=Try ${"Los Angeles"} but it doesn't work here.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls, feel free to ask for some help with those quotes in the chat

@YevhenRDoIT YevhenRDoIT closed this Aug 9, 2024
@YevhenRDoIT YevhenRDoIT reopened this Aug 9, 2024
@YevhenRDoIT
Copy link
Author

I found this syntax way: placeholder="Try "Los Angeles"" but still I can't pass the test.

@YevhenRDoIT YevhenRDoIT closed this Aug 9, 2024
@YevhenRDoIT YevhenRDoIT reopened this Aug 9, 2024
@YevhenRDoIT
Copy link
Author

I found syntax ways to solve it, as follows: placeholder="Try "Los Angeles"" and when I run this command -> 'npm run lint' the following syntax automatically changes to placeholder='Try "Los Angeles"' and in result test can't be passed. Sorry but its really wierd and I think that something is wrong while lint checks for errors following syntax code: placeholder="Try "Los Angeles"". So I had to use following syntax to at least push it: placeholder="Try 'Los Angeles'"

@YevhenRDoIT YevhenRDoIT closed this Aug 9, 2024
@YevhenRDoIT YevhenRDoIT reopened this Aug 9, 2024
@YevhenRDoIT
Copy link
Author

I just updated value of attribute 'placeholder' in index.html. And it shows that tests are passed. Please check it and approve it. Thank you )

Copy link
Author

@YevhenRDoIT YevhenRDoIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates in placeholder

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

Comment on lines +28 to +29
- [DEMO LINK](https://YevhenRDoIT.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://YevhenRDoIT.github.io/layout_search-bar-airbnb/report/html_report/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these links to the PR description
image

Comment on lines +22 to +23
font-family: Avenir, sans-serif;
font-size: 16px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move font styles to the html selector

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this comment still not fixed, I approved your solution, but in the future you should to add these links to the PR description
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants