Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search #4420

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

search #4420

wants to merge 3 commits into from

Conversation

Rostmas-gr
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
The input should span the entire height of the form
image
image

}

body {
font-family: Avenir, sans-serif;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move font styles to the html selector

src/style.css Outdated
Comment on lines 15 to 16
flex-direction: column;
align-items: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant

Suggested change
flex-direction: column;
align-items: center;

box-shadow: 0 4px 4px rgba(0, 0, 0, 0.2);
}

.search--small input {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add classes for inputs and use them as css selectors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add classes for inputs and use them as css selectors

я не зовсім розумію як це потрібно виправити

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this comment still not fixed from the previous review, also, you need to make a deploy after your changes
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your demo link hasn't a styles now, you need to run deploy again and check it after on the demo link
image

font-weight: 300;
}

.html {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.html {
html {

box-shadow: 0 4px 4px rgba(0, 0, 0, 0.2);
}

.search--small input {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants