add task solution #4427
Open
add task solution #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodymyrKirichenko
suggested changes
Aug 14, 2024
src/style.css
Outdated
| font-family: inherit; | ||
| outline: none; | ||
|
|
||
| /* font-weight: 400; */ |
There was a problem hiding this comment.
delete all the comments from CSS file
src/style.css
Outdated
| .form__search-bar:focus { | ||
| border-radius: 3px; | ||
| font-weight: 900; | ||
| background: linear-gradient(180deg, var(--background-color) 0%, #f6f6f7 100%); |
There was a problem hiding this comment.
use variables for all colors
src/style.css
Outdated
Comment on lines
89
to
93
| background-image: url(./images/Search.svg); | ||
| position: absolute; | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| background-size: contain; |
There was a problem hiding this comment.
use background property for this as you did above
BudnikOleksii
approved these changes
Aug 14, 2024
| @@ -1 +1,106 @@ | |||
| /* add styles here */ | |||
| /* #region PAGE */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, locally all 6 tests are passed, but here they failed:
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️