Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4433

wants to merge 2 commits into from

Conversation

kovaden414
Copy link

  • DEMO LINK
  • TEST REPORT LINK
  • [+] Icon implemented using background-image CSS property
  • [+] Inputs are written inside of 'form' tag with correctly passed attributes
  • [+] All Typical Mistakes from BEM lesson theory are checked.
  • [+] Code follows all the Code Style Rules ❗️

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 17, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
You don't need to hide search icon when input is focused
image
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Aug 18, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The image disappears on the focus. Consider fixing it https://www.w3schools.com/css/css3_backgrounds.asp

@kovaden414
Copy link
Author

image
Sorry, I don't really understand the mistake.

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 19, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to make deploy again after your change and check it after on the demo link, if you need help feel free in the fe_chat

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 19, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again, still not fixed from the previous review

@kovaden414
Copy link
Author

image
Sorry, demo link should work

lerastarynets
lerastarynets approved these changes Aug 19, 2024
View reviewed changes
Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerastarynets lerastarynets lerastarynets approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kovaden414 @volodymyr-soltys97 @lerastarynets @anastasiiavorobiova